bin/38756: make dumps core on invalid makefile

[dominik%damned.com.pl@localhost]

>Number:         38756
>Category:       bin
>Synopsis:       make dumps core on invalid makefile
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 26 09:10:00 +0000 2008
>Originator:     dominik
>Release:        4.0.0_PATCH
>Organization:
>Environment:
NetBSD kraina-oz.ath.cx 4.0.0_PATCH NetBSD 4.0.0_PATCH (MOJ_KERNEL) #0: Mon May 
 5 15:35:10 CEST 2008  
root%kraina-oz.ath.cx@localhost:/usr/obj/4.0.0_PATH/obj/sys/arch/i386/compile/MOJ_KERNEL
 i386
>Description:
Make dumps core while reading bad makefile, when .for loop isn't ended and in 
loop body is .PHONY rule. Ex. makefile:

FOO= one two
all:
.for BAR in ${FOO}
        echo ${BAR}


.PHONY: all

stack bt:

Program received signal SIGSEGV, Segmentation fault.
0x0804b3e8 in Buf_AddBytes (bp=0x0, numBytes=11, 
    bytesPtr=0x808340a ".PHONY: all") at buf.c:165
165         BufExpand(bp, numBytes);
(gdb) bt
#0  0x0804b3e8 in Buf_AddBytes (bp=0x0, numBytes=11, 
    bytesPtr=0x808340a ".PHONY: all") at buf.c:165
#1  0x080505e6 in For_Eval (line=0x808340a ".PHONY: all") at for.c:285
#2  0x0805c26d in ParseReadLine () at parse.c:2330
#3  0x0805c782 in Parse_File (name=0x8068e4d "Makefile", fd=6) at parse.c:2408
#4  0x08056dd7 in ReadMakefile (p=0x8068e4d, q=0x0) at main.c:1199
#5  0x08056703 in main (argc=1, argv=0xbfbfec68) at main.c:979
>How-To-Repeat:
run make on bad makefile.
>Fix: