Re: VirtualBox guest additions - new failure

[Chavdar Ivanov <ci4ic4%gmail.com@localhost>]

Awesome, thanks! The following does the job:

--- src/VBox/Additions/common/VBoxGuest/VBoxGuest-netbsd.c.ORIG
2021-07-28 17:16:22.000000000 +0100
+++ src/VBox/Additions/common/VBoxGuest/VBoxGuest-netbsd.c
2021-08-09 20:10:02.660642422 +0100
@@ -416,7 +416,10 @@
     if (RT_FAILURE(rc))
         goto fail;

-#if __NetBSD_Prereq__(9,99,82)
+#if __NetBSD_Prereq__(9,99,88)
+    config_found(sc->sc_dev, &am, wsmousedevprint,
+                 CFARGS(.iattr = "wsmousedev"));
+#elif __NetBSD_Prereq__(9,99,82)
     config_found(sc->sc_dev, &am, wsmousedevprint,
                  CFARG_IATTR, "wsmousedev",
                  CFARG_EOL);


On Mon, 9 Aug 2021 at 19:23, Chris Pinnock <cjep%homeworld.netbsd.org@localhost> wrote:
>
> On Mon, Aug 09, 2021 at 05:38:18PM +0100, Chavdar Ivanov wrote:
> > 9.99.88 brought new  /usr/include/sys/device.h and new
> > config_found(9). Consequently vbox guest additions build fails in
> > src/VBox/Additions/common/VBoxGuest/VBoxGuest-netbsd.c:
> >
> > ...
> > #if __NetBSD_Prereq__(9,99,82)
> >     config_found(sc->sc_dev, &am, wsmousedevprint,
> >                  CFARG_IATTR, "wsmousedev",
> >                  CFARG_EOL);
>
> A similar clause is below (see arch/amiga/dev/ms.c 1.41 -> 1.42).
> I think CFARGS(.iattr = "wsmousedev") is what you need.
>
> @@ -203,8 +203,7 @@
>                 sc->sc_ports[i].ms_wsenabled = 0;
>                 sc->sc_ports[i].ms_wsmousedev =
>                     config_found(self, &waa, wsmousedevprint,
> -                       CFARG_IATTR, "wsmousedev",
> -                       CFARG_EOL);
> +                       CFARGS(.iattr = "wsmousedev"));
>  #endif
>
> Chris



-- 
----