Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: PATCH: Relax fdatasync checks to IEEE Std 1003.1-2008

Paul Ripke <> writes:

>> Running atf on a GCP VM. Never run atf before, we'll see how it goes.
> Failed test cases:
>     dev/fss/t_fss:basic, include/t_paths:paths, lib/libarchive/t_libarchive:libarchive,
>     lib/libc/sys/t_ptrace_sigchld:traceme_raise1, lib/libc/sys/t_ptrace_wait:resume,
>     lib/libc/sys/t_ptrace_wait3:resume, lib/libc/sys/t_ptrace_wait4:resume, lib/libc/sys/t_ptrace_wait6:resume,
>     lib/libc/sys/t_ptrace_waitid:syscall_signal_on_sce, lib/libnvmm/t_io_assist:io_assist,
>     lib/libnvmm/t_mem_assist:mem_assist, lib/librumphijack/t_tcpip:http, lib/librumphijack/t_tcpip:nfs,
>     net/arp/t_arp:arp_rtm, net/if_pppoe/t_pppoe:pppoe6_chap, net/if_pppoe/t_pppoe:pppoe6_pap,
>     net/if_pppoe/t_pppoe:pppoe_chap, net/if_pppoe/t_pppoe:pppoe_pap, net/mpls/t_mpls_fw6:mplsfw6,
>     net/mpls/t_mpls_fw64:mplsfw64_expl, net/ndp/t_ndp:ndp_rtm, rump/rumpkern/t_vm:uvmwait,
>     crypto/opencrypto/t_opencrypto:ioctl
> Summary for 854 test programs:
>     8159 passed test cases.
>     23 failed test cases.
>     48 expected failed test cases.
>     1134 skipped test cases.
> I don't have a baseline - so I don't know if anything has changed.
> Glancing thru the above, nothing looks related, but I could run again
> against a pristine kernel?

That would help, and there is

but the problem is that there is a constant stream of commits that cause
new failures.  (We don't require proving that each commit doesn't cause
atf failures, but I personally like to be careful.)

There is also the issue that actually testing fsync* sort of requires
controlled crashes, which is doable but expensive.

We do have fsync tests but no fdatasync tests.  I wonder how much a
naive copy and s/fsync/fdatasync/ test file would make sense.
See src/sys/lib/libc/sys/t_fsync.c

(I am not requesting that you do add atf tests as a precondition for
committing, although I would like to hear that unifi/mongodb3 (without
the patch) works.)

Thanks for working on this.

Home | Main Index | Thread Index | Old Index