Re: PATCH: Relax fdatasync checks to IEEE Std 1003.1-2008

[Paul Ripke <stix%stix.id.au@localhost>]

On Fri, Mar 13, 2020 at 04:12:33PM +1100, Paul Ripke wrote:
> On Thu, Mar 12, 2020 at 09:49:34AM -0400, Greg Troxel wrote:
> > Paul Ripke <stix%stix.id.au@localhost> writes:
> > 
> > > Currently, fdatasync requires a file descriptor open for writing, as
> > > per IEEE Std 1003.1, 2004:
> > > [EBADF]
> > > The fildes argument is not a valid file descriptor open for writing.
> > > https://pubs.opengroup.org/onlinepubs/009695399/functions/fdatasync.html
> > >
> > > While, IEEE Std 1003.1-2008 (and later revisions):
> > > [EBADF]
> > > The fildes argument is not a valid file descriptor.
> > > https://pubs.opengroup.org/onlinepubs/9699919799/functions/fdatasync.html
> > 
> > I didn't realize that there was a change in POSIX.  That makes things
> > quite different.
> 
> Indeed.
> 
> > It would help if someone ran the entire atf test suite; you might
> > install py-anita to do so.
> 
> Running atf on a GCP VM. Never run atf before, we'll see how it goes.

Failed test cases:
    dev/fss/t_fss:basic, include/t_paths:paths, lib/libarchive/t_libarchive:libarchive,
    lib/libc/sys/t_ptrace_sigchld:traceme_raise1, lib/libc/sys/t_ptrace_wait:resume,
    lib/libc/sys/t_ptrace_wait3:resume, lib/libc/sys/t_ptrace_wait4:resume, lib/libc/sys/t_ptrace_wait6:resume,
    lib/libc/sys/t_ptrace_waitid:syscall_signal_on_sce, lib/libnvmm/t_io_assist:io_assist,
    lib/libnvmm/t_mem_assist:mem_assist, lib/librumphijack/t_tcpip:http, lib/librumphijack/t_tcpip:nfs,
    net/arp/t_arp:arp_rtm, net/if_pppoe/t_pppoe:pppoe6_chap, net/if_pppoe/t_pppoe:pppoe6_pap,
    net/if_pppoe/t_pppoe:pppoe_chap, net/if_pppoe/t_pppoe:pppoe_pap, net/mpls/t_mpls_fw6:mplsfw6,
    net/mpls/t_mpls_fw64:mplsfw64_expl, net/ndp/t_ndp:ndp_rtm, rump/rumpkern/t_vm:uvmwait,
    crypto/opencrypto/t_opencrypto:ioctl

Summary for 854 test programs:
    8159 passed test cases.
    23 failed test cases.
    48 expected failed test cases.
    1134 skipped test cases.

I don't have a baseline - so I don't know if anything has changed.
Glancing thru the above, nothing looks related, but I could run again
against a pristine kernel?

-- 
Paul Ripke
"Great minds discuss ideas, average minds discuss events, small minds
 discuss people."
-- Disputed: Often attributed to Eleanor Roosevelt. 1948.