Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: 800+ tests failing

On Wed, 10 Aug 2016, Martin Husemann wrote:

On Tue, Aug 09, 2016 at 09:12:57AM +0000, Martin Husemann wrote:
This is a call to in_control() with ifp = NULL.

Here is a trace with symbols:

tc-se:#5  0x00007f7ff68637db in panic (fmt=<optimized out>) at /usr/src/lib/librump/../../sys/rump/../kern/subr_prf.c:258
tc-se:#6  0x00007f7ff7085d3a in in_control0 (ifp=0x0, data=0x7f7fffffd4e0, cmd=2151704858, so=<optimized out>) at /usr/src/sys/rump/net/lib/libnet/../../../../netinet/in.c:466
tc-se:#7  in_control (so=<optimized out>, cmd=2151704858, data=0x7f7fffffd4e0, ifp=0x0) at /usr/src/sys/rump/net/lib/libnet/../../../../netinet/in.c:743
tc-se:#8  0x00007f7ff7400c81 in rumpcompinitRUMP_COMPONENT_NET_IFCFG () at /usr/src/sys/rump/net/lib/libnetinet/netinet_component.c:90
tc-se:#9  0x00007f7ff689f0b8 in rump_component_init (type=RUMP_COMPONENT_NET_IFCFG) at /usr/src/lib/librump/../../sys/rump/librump/rumpkern/rump.c:606
tc-se:#10 0x00007f7ff689f0b8 in rump_component_init (type=type@entry=RUMP__FACTION_NET) at /usr/src/lib/librump/../../sys/rump/librump/rumpkern/rump.c:606
tc-se:#11 0x00007f7ff689f604 in rump_init () at /usr/src/lib/librump/../../sys/rump/librump/rumpkern/rump.c:433

So: lo0ifp is NULL, since loopinit() has never been called (or if_loop.c
is not part of the rump libnetinet component?)

Paul? Christos?

How is this supposed to happen? Mark all ${cloner}init() functions as
constructors in the rump case?

I'm really off-line, with only Email access, so cannot look very closely.

However, I don't think the suggestion will work. All the ${cloner}init routines will already be called as part of rump's module initialization, so it doesn't make sense to me to call them again as a rump constructor.

I will have normal access in early Sept. but I'm pretty sure you'd like a fix before then. I hope Christos can dive in deeper.

If not, then perhaps all of these changes should be reverted. That's a rather drastic solution, but might be necessary.

| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:      |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at |

Home | Main Index | Thread Index | Old Index