Re: -fstrict-overflow and -Wstrict-overflow

[David Holland <dholland-current%netbsd.org@localhost>]

On Sat, Oct 13, 2012 at 09:20:08PM +0000, David Holland wrote:
 > However, I draw everyone's attention to the remaining failure in
 > games/gomoku, on line 682 of pickmove.c:
 > 
 > 681:       verts = checkframes(cbp, ocbp, osp, s, vertices);
 > 682:       if (verts < 0)
 > 
 > where checkframes() is a nontrivial 130-line function.
 > 
 > I don't think this one is going to get "fixed" anytime soon.

Also, most of the stuff I've been fixing is ancient code of the form

   for (ptr = array; ptr < &array[max]; ptr++) { ... }

which is worth tidying up but not incorrect. While I've run across a
couple bugs in nearby code, I haven't seen a true positive from the
warning yet. Given that src/games contains a much of the oldest and
cruftiest code in the tree, I think that's a sign it's not worth
dealing with until gcc gets smarter.

-- 
David A. Holland
dholland%netbsd.org@localhost