Re: netbsd-7 on intel GPU (improvements and regressions)

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Thu, Jan 15, 2015 at 11:38:05AM +1100, matthew green wrote:
> 
> there seems to be an i386 GL problem, it was introduced after
> the mesa 10 upgrade, i'm fairly sure, but i have not looked
> closely at it yet.  it occurs on radeon as well.

At last I found why it happens on i386 and not amd64; the attached
patch makes it work on i386 for me.
On amd64 version, an assembly version of the functions in
dist/src/mapi/entry.c is used only when GLX_USE_TLS is defined.
On i386, there are assembly versions for both GLX_USE_TLS and !GLX_USE_TLS
cases. I guess the assembly version is wrong, but I've not looked closely.
The attached patch makes i386 use the C version as amd64 does, and makes it
work.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--

Index: dist/src/mapi/entry.c
===================================================================
RCS file: /cvsroot/xsrc/external/mit/MesaLib/dist/src/mapi/entry.c,v
retrieving revision 1.1.1.1.2.2
diff -u -p -u -r1.1.1.1.2.2 entry.c
--- dist/src/mapi/entry.c	5 Jan 2015 20:59:09 -0000	1.1.1.1.2.2
+++ dist/src/mapi/entry.c	16 Jan 2015 12:06:55 -0000
@@ -39,7 +39,7 @@
 #define ENTRY_CURRENT_TABLE_GET U_STRINGIFY(u_current_get_table_internal)
 #endif
 
-#if defined(USE_X86_ASM) && defined(__GNUC__)
+#if defined(USE_X86_ASM) && defined(__GNUC__) && defined(GLX_USE_TLS)
 #   ifdef GLX_USE_TLS
 #      include "entry_x86_tls.h"
 #   else