Re: Updated drm code

[FUKAUMI Naoki <fun%naobsd.org@localhost>]

hi

At Tue, 16 Jun 2009 19:56:01 +0300,
Arto Huusko wrote:
> I made a new tarball that contains your fixes, and some more fixes by
> me, detailed below. With these changes, my Radeon HD 3870 now works.
> I didn't test yet much more than plain X and XVideo, though.
> 
> The new tarball is available at the same address as previous:
> 
> http://maailma.homeip.net/netbsd/nbsddrm.tgz

on i386, I got

/usr/src/sys/external/bsd/drm/dist/bsd-core/drm_drv.c: In function 'drm_attach':
/usr/src/sys/external/bsd/drm/dist/bsd-core/drm_drv.c:372: warning: format 
'%zx' expects type 'size_t', but argument 7 has type 'bus_size_t'

so I changed

diff -upr nbsddrm/bsd-core/drm_drv.c 
/home/fun/src/sys/external/bsd/drm/dist/bsd-core/drm_drv.c
--- nbsddrm/bsd-core/drm_drv.c  2009-06-12 00:16:39.000000000 +0900
+++ /home/fun/src/sys/external/bsd/drm/dist/bsd-core/drm_drv.c  2009-06-18 
16:07:42.000000000 +0900
@@ -369,7 +369,7 @@ drm_attach(device_t kdev, struct pci_att
                if (dev->pci_map_data[unit].maptype
                     == (PCI_MAPREG_TYPE_MEM | PCI_MAPREG_MEM_TYPE_64BIT))
                        dev->pci_map_data[unit].flags |= BUS_SPACE_MAP_LINEAR;
-               DRM_DEBUG("pci resource %d: type=%d, base=%lx, size=%zx, 
flags=%x\n",
+               DRM_DEBUG("pci resource %d: type=%d, base=%lx, size=%lx, 
flags=%x\n",
                        unit, dev->pci_map_data[unit].maptype,
                        dev->pci_map_data[unit].base,
                        dev->pci_map_data[unit].size,


with new tarball, i915drm reports an error on attach.

i915drm0 at vga1error: [drm:pid0:drm_attach] *ERROR* pci_mapreg info for 32 
failed
error: [drm:pid0:drm_attach] *ERROR* pci_mapreg info for 36 failed
i915drm0: AGP at 0xd0000000 256MB
i915drm0: Initialized i915 1.6.0 20080730

but it seems working as before.

I'll try radeondrm tomorrow.

--
FUKAUMI Naoki