Re: rpcgen(1), issues with System XVI

[christos%astron.com@localhost (Christos Zoulas)]

In article <55FEA6A4.5060908%gmx.com@localhost>, Kamil Rytarowski  <n54%gmx.com@localhost> wrote:
>-=-=-=-=-=-
>
>-----BEGIN PGP SIGNED MESSAGE-----
>Hash: SHA256
>
>On 20.09.2015 13:29, Paul Goyette wrote:
>> On Sun, 20 Sep 2015, Kamil Rytarowski wrote:
>> 
>>> --[PinePGP]--------------------------------------------------[begin]-
>- -
>>>
>>> 
>I was playing with System XVI [1] and I have found two bugs in rpcgen(1)
>>> : - NULL pointer dereference in rpc_hout.c:pargdef(), -
>>> generating invalid symbol names for header guards.
>>> 
>>> The patches are attached to this mail.
>>> 
>>> OK to commit?
>> 
>> The first one looks OK.  I'm not sufficiently familiar with the rpc
>> code to tell if the second patch (symbol manipulation) is correct.
>> It LGTM but would prefer you wait on this until someone else gives
>> a "GO".
>> 
>
>Thanks!
>
>I'm adding new patch against rpcgen(1).
>
>For newstyle we generate oldstyle code. This bug has been fixed in
>FreeBSD on 13 Dec 1995 by wpaul [1].
>
>With this third patch I have got more progress in porting.
>
>OK to commit?

Yes...

christos