tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Adding missing __printflike attributions



On Sun, Mar 04, 2012 at 01:45:33PM -0500, Julio Merino wrote:
> On 3/1/12 5:59 PM, Joerg Sonnenberger wrote:
> >Index: external/bsd/atf/dist/atf-c/error.h
> >===================================================================
> >RCS file: /home/joerg/repo/netbsd/src/external/bsd/atf/dist/atf-c/error.h,v
> >retrieving revision 1.1.1.4
> >diff -u -p -r1.1.1.4 error.h
> >--- external/bsd/atf/dist/atf-c/error.h      16 Jan 2012 22:36:30 -0000      
> >1.1.1.4
> >+++ external/bsd/atf/dist/atf-c/error.h      1 Mar 2012 22:16:13 -0000
> >@@ -62,7 +62,7 @@ void atf_error_format(const atf_error_t,
> >   * Common error types.
> >   * --------------------------------------------------------------------- */
> >
> >-atf_error_t atf_libc_error(int, const char *, ...);
> >+atf_error_t atf_libc_error(int, const char *, ...) __printflike(2, 3);
> >  int atf_libc_error_code(const atf_error_t);
> >  const char *atf_libc_error_msg(const atf_error_t);
> 
> For files within atf, please do:
> 
> ATF_DEFS_ATTRIBUTE_FORMAT_PRINTF(2, 3)
> 
> and include atf-c/defs.h as necessary.

Well, I'd prefer if you just add the correct changes in your repo and
import a new point release.

Joerg


Home | Main Index | Thread Index | Old Index