tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Proposal: fpos_t and funopen(3) API change



On Tue, Mar 29, 2011 at 01:05:27AM +0000, YAMAMOTO Takashi wrote:
> hi,
> 
> > On Tue, Mar 22, 2011 at 03:50:13AM +0900, Takehiko NOZAKI wrote:
> >> ftp://ftp.netbsd.org/pub/NetBSD/misc/tnozaki/patch-fpos_t
> >> 
> >> any comment?
> > 
> > funopen should be versioned as well. Don't change the type of _offset in
> > FILE. Please make it an unused field and add it to the internal side
> > allocation. That one is not part of the public stdio interface, so it
> > doesn't matter if the size changes. This needs a compat flag for funopen
> > usage or so to wrap the old style seek function in some sane way.
> > 
> > Joerg
> 
> what would versioning funopen help?  his patch seems to keep funopen ABI.

Only if the ABI had no padding for fpos_t before, right? Hm. it might
have been broken in that case before already.

Joerg


Home | Main Index | Thread Index | Old Index