tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: mounting wedges by name (Christos Zoulas) writes:

>Looks good:

>- you could make the mib array static const.

The other uses (say in vmstat) all initialize an auto array.

>- there are some missing spaces after commas.
>- I prefer to write the strtok loops:
>       for (p = strtok(array, " "); p; p = strtok(NULL, " "))

That's just copy&paste from another such loop in the same file.

>- I think you really need to use iconv instead of casting the utf8 and using
>  strcmp.

I had some private discussion about this. Pathnames aren't
interpreted according to locale, why should partition names
be different? Also, there could be partition names that have no
valid representation in the current locale.

How would iconv impact say /rescue/mount ?

                                Michael van Elst
                                "A potential Snark may lurk in every tree."

Home | Main Index | Thread Index | Old Index