Re: WARNS=5 breaks with old gcc

[David Brownlee <abs%netbsd.org@localhost>]

On 24 June 2012 16:19, Nicolas Joly <njoly%pasteur.fr@localhost> wrote:
> On Sun, Jun 24, 2012 at 06:58:07PM +1000, matthew green wrote:
>>
>> > As can be seen on the NetBSD/vax -current builds, WARNS=5 does not properly
>> > work with gcc 4.1.
>> >
>> > Is the following patch correct?
> [...]
>> i'm confused.  the error at hand is about this code:
>>
>> int
>> getdtablesize()
>> {
>>         return ((int)sysconf(_SC_OPEN_MAX));
>> }
>>
>> compaining that it should be getdtablesize(void).  which is right.
>> imo, this code should be changed instead of the warning disabled.
>>
>> another question is why doesn't this trigger for gcc 4.5?  maybe
>> the warning was downgraded when the prototype already has (void)
>> (as unistd.h has.)
>
> No idea why, but gcc 4.5 does not complain about old style definitions
> for system headers.

How terribly unhelpful. I believe I have a set of changes which
address all the old-style warnings reporting in the vax build. As soon
as a gcc-4.1 vax & gcc4.5 amd64 build complete I'll commit.