tech-toolchain archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: make: don't use bogus $TMPDIR

On Thu, 22 Apr 2010 17:41:03 +0000, David Holland writes:
>On Thu, Apr 22, 2010 at 12:36:12AM -0700, Simon J. Gerraty wrote:
> > Job_Init was using $TMPDIR from the environment, but that doesn't
> > ensure it is valid....
> > 
> > I've a need for this in more than one place so making tmpDir a global.
>Looks reasonable, except that if it were me I'd centralize the code
>for setting up a temporary file, and make the tmpdir variable private

The other place I use tmpDir is in the meta mode stuff - which I'll be
following up on in due course.
I could make the change you suggest easily enough.

>You also included the previous patch in this one :-p

Well I didn't want to commit it without giving folk a chance to comment

Home | Main Index | Thread Index | Old Index