Final USE_INDIRECT_DEPENDS proposed patch

[Jonathan Perkin <jperkin%mnx.io@localhost>]

* On 2024-10-03 at 10:27 BST, Jonathan Perkin wrote:

> I spent yesterday re-reviewing this and double checking things, and 
> ended up redoing parts of it.  The current proposed commit is here:
>
>  https://github.com/TritonDataCenter/pkgsrc/commit/3103b3a5fdfd3c127e9851cfd348f2f9ca2e92e5
>
> I'm happier with the wording, variable name, and code changes compared 
> to the previous patch.  I will do one last set of local tests before 
> merging this.

My final round of bulk build testing exposed an issue, so I've updated 
the patch again, hopefully for a final time:

  https://github.com/TritonDataCenter/pkgsrc/commit/533ec12e765192fda72e58dce0e60a810b6a122b

This completed in my from-scratch SmartOS bulk build this morning using 
USE_INDIRECT_DEPENDS=no (i.e. the default) with no apparent issues.  I 
am running it again from scratch with USE_INDIRECT_DEPENDS=yes enabled 
to verify and compare.

I'm also testing it in my latest macOS bulk build with 
USE_INDIRECT_DEPENDS enabled, though I've needed to work around the 
php-iconv issue to get that running.  That one is using mktool, but 
appears to be correctly identifying bad includes, e.g.:

  gnuradio-zeromq-3.10.9.2nb4/install.log:ERROR: lib/libgnuradio-zeromq.3.10.9.2.dylib: /opt/pkg/lib/libzmq.5.dylib: zeromq-4.3.5nb1 is not a runtime dependency

which is caused by net/cppzmq's incorrect use of DEPMETHOD=build.

This touches some very fundamental parts of the infrastructure, so I 
would really appreciate someone taking a good look at this to ensure 
that all my testing hasn't missed something.

Thanks,

--
Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com