tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Summary of implicit DEPENDS problem



Jonathan Perkin <jperkin%mnx.io@localhost> writes:

> A simpler fix that may work for many cases that I thought about this
> morning is what I just committed to vala, i.e.:
>
>   lang/vala/buildlink3.mk:
>    +.if ${BUILDLINK_DEPMETHOD.vala:U:Mfull}
>     .include "../../devel/glib2/buildlink3.mk"
>     .include "../../devel/libltdl/buildlink3.mk"
>     .include "../../graphics/graphviz/buildlink3.mk"
>    +.endif
>
> If a bl3 is included for the sole purpose of a build dependency, which
> is usually just to run some tools, then I think the for the vast
> majority of situations you are not going to need the implicit
> dependencies.  They should only be required when linking, and if we're
> linking against this libraries from this package then it should not be
> a "build" dependency.
>
> Another idea I just considered is that we move away from having
> packages set BUILDLINK_DEPMETHOD.foo=build themselves, make that a
> pkglint error, and instead have explicit bl3 files that should be used
> for the "build" case that do not include other bl3 files.  For example
> lang/vala/tool.mk that would have to duplicate a few bits like
> BUILDLINK_API_DEPENDS, but would contain any logic required to run the
> tools and no other includes.

This makes a lot of sense.  We are abusing bl3 for tool dependencies,
and maybe the best path is "don't do that".


Home | Main Index | Thread Index | Old Index