Re: nawk-20230911 problem

[Paolo Vincenzo Olivo <vins%netbsd.org@localhost>]

Hi Adam,

On 23/09/16 10:04AM, Adam wrote:
> Greetings,
> 
> I can't build mozilla-rootcerts with the latest nawk (20230911). Version 20220122 seems to be fine.
> 
> This is on macOS:
> 
> ===> Building for mozilla-rootcerts-1.0.20230720
> /bin/mkdir -p /tmp/pkgsrc/security/mozilla-rootcerts/work/certs
> cd /tmp/pkgsrc/security/mozilla-rootcerts/work/certs &&  /dist/pkg/bin/mksh /tmp/pkgsrc/security/mozilla-rootcerts/work/mozilla-rootcerts.sh -f /tmp/pkgsrc/security/mozilla-rootcerts/work/certdata.txt extract
> mozilla-rootcert-0.pem
> unable to load certificate
> 8014402304:error:0D07207B:asn1 encoding routines:ASN1_get_object:header too long:crypto/asn1/asn1_lib.c:101:
> 
> ...
> 
> 
> Please, advise.
> Adam

Apparently nawk 2nd edition (20230911) expects input to be UTF-8
encoded, and won't parse octal-encoded DER certificates. See the BUGS
section in the latest nawk(1). 
I think this represents a major breakage in awk behavior, and probably
needs to be addressed with regard to the pkgsrc use case, considering
how critical the package is. 

The 'csv' branch pulling the change was merged in 20230911 [1], right
before tagging the 2nd edition. 
The last backward compatible release tag is dated 20230909 (maybe now I
understand why). This contains all the fixes found in 20230911, minus
support for UTF-8 and comma-separated values (CSV) input.

I was able to reproduce the issue on my system (NetBSD 10.0_BETA, with 
nawk-20230911 installed, and using `TOOLS_PLATFORM.awk=/usr/pkg/bin/nawk'
in mk.conf).
I hereby locally downgraded the package to 20230909. With nawk-20230909,
I could confirm that mozilla-rootcerts are extracted fine, and that the
problem is solved.

Now, in my opinion the most rational way to work this out - at least for
pkgsrc-2023Q3 - is to downgrade lang/nawk to 20230909, and package
20230911 separately, as lang/nawk2 or lang/awk2 (with distfiles to be
fetched remotely). Does this look reasonable?

[1] https://github.com/onetrueawk/awk/commit/0a497bc5a1ad26e21a0e5018e884c7435b112c53

Regards,
Paolo