focuswriter build issue on 9 only

[pin <voidpin%protonmail.com@localhost>]

Hi all,

Could someone shed some light as how to solve the build of editors/focuswriter on NetBSD-9?
It currently fails on mef@ bulkbuilds at the configure stage with,

-- Performing Test Iconv_IS_BUILT_IN
-- Performing Test Iconv_IS_BUILT_IN - Failed
CMake Error at /usr/pkg/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Iconv (missing: Iconv_LIBRARY)
Call Stack (most recent call first):
  /usr/pkg/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  /usr/pkg/share/cmake-3.27/Modules/FindIconv.cmake:165 (find_package_handle_standard_args)
  CMakeLists.txt:23 (find_package)


-- Configuring incomplete, errors occurred!
*** Error code 1

On my machine (amd64) running 10.99.8 from the 9th of September it builds just fine.

I've discussed this on a private thread with wiz@ that has suggested that "perhaps the prototype for iconv() that was changed in -current to be
less correct but more like other implementations." is the cause of it.

Indeed from from work/focuswriter-1.8.5/cmake-pkgsrc-build/CMakeFiles/CMakeConfigureLog.yaml

        /usr/pkgsrc/editors/focuswriter/work/focuswriter-1.8.5/cmake-pkgsrc-build/CMakeFiles/CMakeScratch/TryCompile-hv9FEC/src.cxx: In function 'int main()':
        /usr/pkgsrc/editors/focuswriter/work/focuswriter-1.8.5/cmake-pkgsrc-build/CMakeFiles/CMakeScratch/TryCompile-hv9FEC/src.cxx:9:19: error: invalid conversion from 'char**' to 'const char**' [-fpermissive]
            9 |         iconv(ic, &a, &i, &b, &j);
              |                   ^~
              |                   |
              |                   char**
        In file included from /usr/pkgsrc/editors/focuswriter/work/focuswriter-1.8.5/cmake-pkgsrc-build/CMakeFiles/CMakeScratch/TryCompile-hv9FEC/src.cxx:3:
        /usr/include/iconv.h:46:23: note:   initializing argument 2 of 'size_t iconv(iconv_t, const char**, size_t*, char**, size_t*)'
           46 | size_t iconv(iconv_t, const char ** __restrict,
              |                       ^

But, we don't really know how to fix it or work around this.

Thank you!
/Pedro


Sent with Proton Mail secure email.