tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: import wip/unit



On 07.02.2021 18:54, Sergey A. Osokin wrote:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=blob;f=unit/patches/patch-src_nxt__php__sapi.c
looks strange not only for you, but for the Unit development team as well.
From other side, otis@ added that patch to the package due to a build
error on NetBSD-current.

This one needs to be fixed properly.  I won't accept any patch that
"fixes" the ctype.h compiler warning in a wrong way, and I hope no one
else will.

More details: https://stackoverflow.com/a/60696378

It's good that the Unit team doesn't like this patch either.  This means
they know their programming language.

https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=blob;f=unit/patches/patch-src_nxt__kqueue__engine.c
is related to NetBSD-current only.

I'm fine with this patch.  As soon as NetBSD 10 is released, this patch
should be sent upstream nevertheless.


Home | Main Index | Thread Index | Old Index