news/neix

[voidpin <voidpin%protonmail.com@localhost>]

Hi all,

There seems to be some issues with a package I've pushed recently, news/neix

The package builds, installs and works fine on my system. I've asked @maya to
double-check it, before posting here, and she confirmed that the package works
for her as well.

==========
$ uname -a
NetBSD mybox 9.99.77 NetBSD 9.99.77 (GENERIC) #0: Wed Jan 13 15:51:49 UTC 2021
mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/amd64/compile/GENERIC amd64
==========

FY, /etc/mk.conf

# mk.conf
NETBSD_LOGIN_NAME=pin
ALLOW_VULNERABLE_PACKAGES=1
MAKE_JOBS=4
PKG_DEVELOPER=yes
RUST_TYPE=src
PKG_DBDIR=/usr/pkg/pkgdb
PKG_TOOLS_BIN=/usr/pkg/sbin

Also, the package builds fine for @jperkin,
https://us-east.manta.joyent.com/pkgsrc/public/reports/NetBSD/trunk/x86_64/20210113.0832/meta/report.html

But it has failled twice now on @mef's builds,
http://www.ki.nu/pkgsrc/reports/current/NetBSD-9.0/20210112.0123/meta/report.html

with the follwing error:

==========
=> Bootstrap dependency digest>=20010302: found digest-20190127
===> Skipping vulnerability checks.
WARNING: No /usr/pkg/pkgdb/pkg-vulnerabilities file found.
WARNING: To fix run: `/usr/sbin/pkg_admin -K /usr/pkg/pkgdb fetch-pkg-vulnerabilities'.
===> Installing for neix-0.1.3
=> Generating pre-install file lists
[ 16%] Built target neixFeed
[ 33%] Built target neixApplication
[ 44%] Built target neixHelper
[ 72%] Built target neixParser
[ 88%] Built target neixConfig
[100%] Built target neix
Install the project...
-- Install configuration: ""
-- Installing: /tmp/news/neix/work/.destdir/usr/pkg/bin/neix
-- Installing: /tmp/news/neix/work/.destdir/usr/pkg/man/man1/neix.1
-- Installing: /tmp/news/neix/work/.destdir/usr/pkg/share/neix/neix.conf
-- Installing: /tmp/news/neix/work/.destdir/usr/pkg/share/neix/feeds.conf
=> Automatic manual page handling
=> Generating post-install file lists
=> Checking file-check results for neix-0.1.3
=> Checking for non-existent script interpreters in neix-0.1.3
=> Checking file permissions in neix-0.1.3
=> Checking for missing run-time search paths in neix-0.1.3
=> Checking for work-directory references in neix-0.1.3
ERROR: /usr/pkg/bin/neix:	Binary file /tmp/news/neix/work/.destdir/usr/pkg/bin/neix matches
ERROR: *** The above files still have references to the build directory.
ERROR:     This is possibly an error that should be fixed by unwrapping
ERROR:     the files or adding missing tools to the package makefile!
*** Error code 1

Stop.
make[1]: stopped in /amd/pkgsrc/CHROOT/P/pkgsrc/news/neix
*** Error code 1

Stop.
make: stopped in /amd/pkgsrc/CHROOT/P/pkgsrc/news/neix
==========

After a short discussion with @nia, I believe I know why it's failling...

==========
$ strings /usr/pkg/bin/neix
...
HOME
/.config/neix/tmp-raw.txt
invalid numeric character entity
rapidxml::xml_node<Ch>* rapidxml::xml_node<Ch>::next_sibling(const Ch*, std::size_t, bool) const [with Ch = char; std::size_t = long unsigned int]
/home/pbulk/build/news/neix/work/neix-0.1.3/include/rapidxml/rapidxml.hpp
void rapidxml::xml_document<Ch>::parse(Ch*) [with int Flags = 1024; Ch = char]
vector::_M_range_check: __n (which is %zu) >= this->size() (which is %zu)
/.config/neix/tmp-rendered.txt
expected >
expected ;
memory
...
==========

As you can see a path to the build-directory somehow got embedded into it.

Does this need to be fixed and any hints on how?
What should I have in /etc/mk.conf to catch things like this?

TIA,
pin


Sent with ProtonMail Secure Email.