Re: How to patch a crate?

[voidpin <voidpin%protonmail.com@localhost>]

Thanks, I'll look into it.

I'm still unsure how to patch it, though.
Also 'get_if_addrs' is archived and no longer maintained.
I don't believe patches will be merged and is not possible
to do pull-requests.

I still have to think a bit more about it.
I'm planning to package, actually already did but, its not
finished yet, a GUI Spotify client.
This requires a actual back-end hence, my interest in 'librespot'.

Although, I've noticed 'ncspot' uses the following components,
'librespot-audio', 'librespot-core', 'librespot-metadata',
'librespot-playback' and 'librespot-protocol', i.e. it leaves out 'librespot-connect', the crate depending on 'get_if_addrs'.

I could, either call 'ncspot' as the backend for the GUI-client or,
try packaging the 'librespot' sub-crates by themselves.
The first alternative feels a bit bloated and the second a bit hard
to achieve, as the GUI frontend is not a rust app and calling
sub-crates as dependencies is still a bit unclear to me.

Anyway, thanks for the hint and thanks once again for the help
packaging 'ncspot'


Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Friday, August 28, 2020 3:52 PM, Tobias Nygren <tnn%NetBSD.org@localhost> wrote:

> On Fri, 28 Aug 2020 11:10:36 +0000
> voidpin voidpin%protonmail.com@localhost wrote:
>
> > I'm trying to build 'librespot' in wip but, I'm getting a Rust "out-of-scope" error
> > while compiling 'get_if_addrs', one of the dependency crates.
> > Unfortunately, 'get_if_addrs' is a archived crate.
> > Is it possible to patch a crate? If so, what's the recommended way to do this?
>
> Yes. You can create a patch relative to WRKSRC.
> See
> wip/alacritty/patches/patch-vendor_winit_src_platform__impl_linux_mod.rs
> for a current example. It is not ideal to do this because it generates
> a pkglint warning, but it works.
> Please also send the patch to the upstream crate maintainer.
>
> -Tobias