Removing uuid bl3 inclusion from fonts/fontconfing/buildlink3.mk (was: Re: Making builtin fontconfig usable again on NetBSD)

[Leonardo Taccari <leot%NetBSD.org@localhost>]

(Subject: updated to reflect new proposal)

Thomas Klausner writes:
> On Fri, Jul 10, 2020 at 01:11:42PM +0200, Leonardo Taccari wrote:
> > Thomas, do you recall why libuuid bl3 was added to fontconfig
> > buildlink3? (cvs log does not seem to help)
>
> I guess because it is linked into libfontconfig.so:
>
> # ldd work/.destdir/usr/pkg/lib/libfontconfig.so
> work/.destdir/usr/pkg/lib/libfontconfig.so:
>         -lfreetype.19 => /usr/X11R7/lib/libfreetype.so.19
>         -lz.1 => /usr/lib/libz.so.1
>         -lc.12 => /usr/lib/libc.so.12
>         -lbz2.1 => /usr/lib/libbz2.so.1
>         -lexpat.2 => /usr/lib/libexpat.so.2
>         -luuid.1 => /usr/pkg/lib/libuuid.so.1
>         -lintl.1 => /usr/lib/libintl.so.1
>         -lgcc_s.1 => /usr/lib/libgcc_s.so.1
>
> The pkgconfig file claims it's a private dependency only though:
>
> Requires.private:  uuid
>
> so we might be able to just remove libuuid from the bl3.mk to fix
> this.
>

Thanks!

If that's the case I propose to remove libuuid bl3 inclusion directly
in fonts/fontconfig/buildlink3.mk.

> > If that libuuid bl3 inclusion is really needed on other platforms is it
> > okay to commit the proposed patch in this email?
>
> I don't understand this part (from your third email):
>
> +.  if !empty(USE_BUILTIN.fontconfig:M[Nn][Oo]) && ${OPSYS} == "NetBSD"
>  .include "../../devel/libuuid/buildlink3.mk"
> +.  endif
>
> libuuid needs to be included when fontconfig is used from pkgsrc,
> independent of OPSYS.
> [...]

Because on NetBSD builtin fontconfig has an internal libuuid
(libuuid_ul) with symbols renamed.