libtool with --tag

[ng0%n0.is@localhost]

Hi folx,

I've been running pkgsrc and base with clang for a short while now
on one system.
I already have 2 bugreports which I should send, but the problems
are always the same, a tiny diff which makes me assume that we can
abstract this into pkgsrc logic.

quoting from my mail to simonb@:

=> Full dependency libmad>=0.15.1bnb1: NOT found
=> Verifying package install for ../../audio/libmad
=> Bootstrap dependency digest>=20010302: found digest-20190127
===> Building for libmad-0.15.1bnb1
/usr/bin/make  all-recursive
if /bin/sh ./libtool --mode=compile clang -DHAVE_CONFIG_H  -I. -I. -I. -DFPM_DEFAULT      -Wall -O2 -MT version.lo -MD -MP -MF
+".deps/version.Tpo" -c -o version.lo version.c;  then mv -f ".deps/version.Tpo" ".deps/version.Plo"; else rm -f
+".deps/version.Tpo"; exit 1; fi
libtool: compile: unable to infer tagged configuration
libtool:   error: specify a tag with '--tag'
*** Error code 1

Stop.
make[2]: stopped in /usr/work/audio/libmad/work/libmad-0.15.1b
*** Error code 1




This hit me so far in:
* libmad
* argp
* wxGTK

Diffs to solve this are already in pkgsrc as patches for
individual packages.

-SH_COMPILE     = $(LIBTOOL) --mode=compile $(BASE_CC) @SHLTCFLAGS@ -c $< && touch $@
-SH_CXX_COMPILE = $(LIBTOOL) --mode=compile $(BASE_CXX) @SHLTCFLAGS@ -c $< && touch $@
+SH_COMPILE     = $(LIBTOOL) --tag=CC --mode=compile $(BASE_CC) @SHLTCFLAGS@ -c $< && touch $@
+SH_CXX_COMPILE = $(LIBTOOL) --tag=CXX --mode=compile $(BASE_CXX) @SHLTCFLAGS@ -c $< && touch $@ 
-LT_CXX_COMPILE = $(LIBTOOL) --mode=compile $(CXX_COMPILE) @LTCFLAGS@ -c $< && touch $@
+LT_COMPILE     = $(LIBTOOL) --tag=CC --mode=compile $(COMPILE) @LTCFLAGS@ -c $< && touch $@
+LT_CXX_COMPILE = $(LIBTOOL) --tag=CXX --mode=compile $(CXX_COMPILE) @LTCFLAGS@ -c $< && touch $@

-LINK     = $(LIBTOOL) --mode=link $(CC) $(ALL_CFLAGS) @PILDFLAGS@ $(LT_LDFLAGS) $(ALL_LDFLAGS) -o $@
-SH_LINK  = $(SH_LIBTOOL) --mode=link $(CC) $(ALL_CFLAGS) $(LT_LDFLAGS) $(ALL_LDFLAGS) $(SH_LDFLAGS) $(CORE_IMPLIB) $(SH_LIBS) -o $@
-MOD_LINK = $(LIBTOOL) --mode=link $(CC) $(ALL_CFLAGS) -static $(LT_LDFLAGS) $(ALL_LDFLAGS) -o $@
+LINK     = $(LIBTOOL) --tag=CC --mode=link $(CC) $(ALL_CFLAGS) @PILDFLAGS@ $(LT_LDFLAGS) $(ALL_LDFLAGS) -o $@
+SH_LINK  = $(SH_LIBTOOL) --tag=CC --mode=link $(CC) $(ALL_CFLAGS) $(LT_LDFLAGS) $(ALL_LDFLAGS) $(SH_LDFLAGS) $(CORE_IMPLIB) $(SH_LIBS) -o $@
+MOD_LINK = $(LIBTOOL) --tag=CC --mode=link $(CC) $(ALL_CFLAGS) -static $(LT_LDFLAGS) $(ALL_LDFLAGS) -o $@



but would there be any harm in patching this into a general libtool modification
phase? Seems more effective to me than patching every single file where it could
occur.


Cheers,
ng0