Re: Switch macOS default bootstrap shell

[Greg Troxel <gdt%lexort.com@localhost>]

Jonathan Perkin <jperkin%joyent.com@localhost> writes:

> Newer macOS releases with SIP enabled can cause problems when trying
> to use certain environment variables such as LD_LIBRARY_PATH under
> system shells, i.e. /bin/*sh.  Currently we have various workarounds
> for this across the tree.
>
> I propose changing bootstrap to default to pdksh for these releases,
> as using a shell outside of system paths still works.
>
> I've tested this in a bulk build using --full, the results of which
> are here:
>
>   https://us-east.manta.joyent.com/pkgsrc/public/reports/Darwin/10.15/trunk/x86_64/20200615.0911/meta/report.html
>
> [snip]
>
> We're quite close to freezing, but I think this should be safe, and
> will resolve some issues that people are seeing.

(Would like to wait 24h for other comments.)

Given that you actually did a bulk build with the change and it's ok, I
think this is fine to go in.   It seems far better to work around mac
issues once than have to have per-package hacks.