Re: Providing an easy additional way of avoiding uploading non-redistributable packages

[coypu%sdf.org@localhost]

On Thu, May 21, 2020 at 12:07:49PM -0400, Greg Troxel wrote:
> coypu%sdf.org@localhost writes:
> 
> > I understand it's a duplicate solution, but I think it's significantly
> > wasteful of admin resources to constantly ping people about it.
> >
> > Index: package/package.mk
> > ===================================================================
> > RCS file: /cvsroot/pkgsrc/mk/package/package.mk,v
> > retrieving revision 1.27
> > diff -u -r1.27 package.mk
> > --- package/package.mk	7 May 2019 19:36:44 -0000	1.27
> > +++ package/package.mk	21 May 2020 15:33:20 -0000
> > @@ -111,6 +111,9 @@
> >  .if defined(NO_BIN_ON_FTP)
> >  	@${WARNING_MSG} "${PKGNAME} may not be made available through FTP:"
> >  	@${WARNING_MSG} ${NO_BIN_ON_FTP:Q}
> > +.if !empty(NO_BIN_ON_FTP_FAIL:M[Yy][Ee][Ss])
> > +PKG_FAIL_REASON+=	"Package cannot be uploaded to FTP, skipping"
> > +.endif
> >  .endif
> >  .if defined(ABI_DEPENDS) && !empty(USE_ABI_DEPENDS:M[Nn][Oo])
> >  	@${WARNING_MSG} "ABI dependency recommendations are being ignored!"
> 
> I'm in favor of this.  In addiiton to avoiding work for people, it also
> means that bulk build machines intending to create redistributable
> packages won't spend cycles building things that are going to be ignored
> anyway.
> 
> 
> Another thought (and I don't mean to demand that anyone implement it) is
> that this problem arises because of the notion that bulk builds disable
> the license check logic.  Normally, only Free or Open Source software is
> built.  So we could, in addition the the undocumented variable to skip
> all license checks, add another variable, perhaps _ACCETPABLE_FTP, that
> skips the license check only if NO_SRC_ON_FTP and NO_BIN_ON_FTP are both
> unset.

I'm tempted to use
SKIP_LICENSE_CHECK=redistributable

It wins on "user friendliness", but possibly looks a bit ugly make-wise,
to have the tunable appear in two disconnected phases.