Providing an easy additional way of avoiding uploading non-redistributable packages

[coypu%sdf.org@localhost]

A frequent issue for admins is that someone is new to building packages,
and they haven't figured out how to upload with pbulk yet, and they
upload a package which isn't redistributable.

I am proposing an additional way to avoid this problem via mk.conf,
which hopefully works better for people who have an awkward rsync setup
and aren't doing uploads through pbulk's script.

It's quite small, and I expect it will make it easier for people to
comply with the rules by adding:

NO_BIN_ON_FTP_FAIL=yes
to their mk.conf

I understand it's a duplicate solution, but I think it's significantly
wasteful of admin resources to constantly ping people about it.

Index: package/package.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/package/package.mk,v
retrieving revision 1.27
diff -u -r1.27 package.mk
--- package/package.mk	7 May 2019 19:36:44 -0000	1.27
+++ package/package.mk	21 May 2020 15:33:20 -0000
@@ -111,6 +111,9 @@
 .if defined(NO_BIN_ON_FTP)
 	@${WARNING_MSG} "${PKGNAME} may not be made available through FTP:"
 	@${WARNING_MSG} ${NO_BIN_ON_FTP:Q}
+.if !empty(NO_BIN_ON_FTP_FAIL:M[Yy][Ee][Ss])
+PKG_FAIL_REASON+=	"Package cannot be uploaded to FTP, skipping"
+.endif
 .endif
 .if defined(ABI_DEPENDS) && !empty(USE_ABI_DEPENDS:M[Nn][Oo])
 	@${WARNING_MSG} "ABI dependency recommendations are being ignored!"