Re: bootstrap: invalid characters in path

[Brook Milligan <brook%nmsu.edu@localhost>]

> On Sep 17, 2019, at 12:44 PM, Roland Illig <roland.illig%gmx.de@localhost> wrote:
> 
> Am September 17, 2019 6:21:34 PM UTC schrieb Brook Milligan <brook%nmsu.edu@localhost>:
>> I am trying an unprivileged install of pkgsrc on a system where my home
>> directory follows the pattern "user%organization.name@localhost".  Of course, the
>> bootstrap script complains about the "@" in the path and quits.
>> 
>> Is this an important character to keep out of the mix?  Would it be
>> acceptable in include it in this list of valid characters?
> 
> I think that a single @ will not cause any problems, as well as a single dot. Therefore it should be safe to allow these characters.
> 
> There might be strange side effects in a few packages if a path contained @prefix@ or "..". But that's not the case, and both the regular expression "." and the shell glob "." match the character ".", therefore it should work.

This patch allows my bootstrap to proceed and I have built a smallish number (~100) of packages just fine.

Cheers,
Brook

--- bootstrap/bootstrap.orig    2019-09-16 10:55:50.664479123 -0600
+++ bootstrap/bootstrap 2019-09-17 12:22:57.431172977 -0600
@@ -353,7 +353,7 @@
 {
        case "$1" in
        "")     ;; # the default value will be used.
-       *[!-A-Za-z0-9_./]*)
+       *[!-A-Za-z0-9_./@]*)
                die "ERROR: Invalid characters in path $1 (from $2)." ;;
        */)     die "ERROR: The argument to $2 must not end in /." ;;
        *//* | */. | */./* | */.. | */../*)