Re: Request for review and import: libxls, libxlsxwriter, sc-im

["Sijmen J. Mulder" <ik%sjmulder.nl@localhost>]

On Tue, 11 Dec 2018 14:39:15 +0100 Benny Siegert <bsiegert%gmail.com@localhost>
wrote:
> Regarding sc-im:
>  - The patch to Makefile is wrong, in that it never uses -ldl. I think
> you should include "../../mk/dlopen.buildlink3.mk" and use the values
> of DL_CFLAGS, DL_LDFLAGS and/or DL_LIBS.

I've updated the package to use dlopen.buildlink3.mk but went with a
BUILDLINK_TRANSFORM approach so no Makefile patches would be necessary:

  BUILDLINK_TRANSFORM+=   opt:-ldl:${BUILDLINK_LDADD.dl:M*}

  .include "../../mk/dlopen.buildlink3.mk"

To test, I've successfully built on Debian, NetBSD, and Void Linux
(which uses musl-libc). But I'm quite out of my depth here so I'm not
sure if this is the best solution.


Something else: on Void Linux (with musl-libc) the lua option breaks
the build in this odd way:

  cc -L/usr/pkg/lib -Wl,-R/usr/pkg/lib xlsx.o cmds_edit.o cmds_visual.o
    history.o marks.o lex.o trigger.o maps.o color.o input.o range.o
    pipe.o dep_graph.o xls.o buffer.o help.o filter.o format.o undo.o
    interp.o hide_show.o lua.o file.o plot.o vmtbl.o cmds_insert.o
    freeze.o block.o tui.o conf.o cmds_normal.o xmalloc.o sort.o main.o
    cmds.o shift.o cmds_command.o yank.o exec.o clipboard.o subtotal.o
    utils/extra.o utils/dictionary.o utils/string.o gram.o -o sc-im -lm
    -pthread -ldl -L/usr/pkg/lib -lncursesw  -Wl,-R/usr/pkg/lib
    -Wl,-R/usr/pkg/lib -L/usr/pkg/lib -llua5.1 -lm  -Wl,--export-dynamic
  /usr/bin/ld: cannot find -l__nonexistent__

All the referenced libraries exists and 'ldd liblua5.1.so' doesn't show
anything odd either. Is something like this considered a blocker? I did
add a TODO note.

Sijmen