tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Request for review and import: libxls, libxlsxwriter, sc-im

Hi Benny,

Op di dec 11 2018, om 14:39 schreef Benny Siegert:
> Regarding libxlsxwriter:
>  - we usually do not explicitly set V=1 in MAKE_ENV. It's fine for
> your debugging, but please remove before importing.

The libxlsxwriter makefile is completely silent without it, isn't that
a bit too quiet? V=1 here is make's regular command echo.

> Regarding sc-im:
>  - The patch to Makefile is wrong, in that it never uses -ldl. I think
> you should include "../../mk/" and use the values
> of DL_CFLAGS, DL_LDFLAGS and/or DL_LIBS. Or perhaps just disable it on
> NetBSD by adding

This looks like a good solution, I'll try it and test on a few

Thanks for reviewing.


Home | Main Index | Thread Index | Old Index