Re: pkgsrc-wip: "../mk/libusb.mk" disappeared?

[Pierre Pronchery <khorben%defora.org@localhost>]

On 29/03/2018 23:20, Pierre Pronchery wrote:
> Sorry, there has been multiple renaming for the mini libusb framework
> before the final version in pkgsrc, so I may have mixed it up when
> reflecting it in wip. I will have a look in a few minutes.

This should now fixed; I just built wip/p2kmoto to be sure.

Sorry again,
-- khorben

> On 29/03/2018 00:03, John D. Baker wrote:
>> On Wed, 28 Mar 2018, John D. Baker wrote:
>>
>>> A few packages in pkgsrc-wip contain:
>>>
>>>   .include "../mk/libusb.mk"
>>>
>>> in their respective "buildlink3.mk" files:
>>>
>>>   gnokii/buildlink3.mk
>>>   libdjconsole/buildlink3.mk
>>>   libftdi1/buildlink3.mk
>>>   p2kmoto/buildlink3.mk
>>>
>>> The path indicates that it's looking for ".../wip/mk/libusb.mk".
>>
>>> Now that I've updated my repo and restored "moto4lin", this mysterious
>>> "../mk/libusb.mk" has gone missing.  I've gone searching through logs
>>> and 'git diff ...' trying to figure out when it was removed, see its
>>> content and figure out with what it shoud be replaced, but I haven't
>>> been able to find it.
>>
>> Using the commit hash just before the removal of qt3-using packages and
>> getting a diff of the repo relative to HEAD, it appears the
>> "../mk/libusb.mk" file was intended to be added, but never was.
>>
>> Each of the above-mentioned packages' "buildlink3.mk" file was changed
>> FROM including "../../devel/libusb/buildlink3.mk" TO including
>> "../mk/libusb.mk".  This occurred with:
>>
>> commit ab7629fb55379deea37740eaa35c41b32fd102eb
>> Author: Pierre Pronchery <khorben%defora.org@localhost>
>> Date:   Mon Feb 26 20:50:26 2018 +0100
>>
>>     Use the new framework for libusb
>>
>>
>> Presumedly, this was to address the "libusb-compat" framework, but
>> it looks like the intended ".../wip/mk/libusb.mk" was never committed.
>>
>> Should pkgsrc "../../mk/libusb.buildlink3.mk" be used in the pkgsrc-wip
>> packages' "buildlink3.mk" file, or use
>> "../../devel/libusb-compat/buildlink3.mk" same as the package Makefile?
>>
>> Thanks.
>>
> 
> 


-- 
khorben