Re: CHECK_PORTABILITY_SKIP and ~ files

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2018-01-14 at 16:37 GMT, Greg Troxel wrote:

> I am checking an rc of a package, and found a new bashism had crept in,
> from check-portability.awk finding "test ==".  To make progress on
> testing, I edited configure after unpacking, and that left configure.~1~
> with "test ==", which then failed.
> 
>   ERROR: [check-portability.awk] configure.~1~: if test
>   "x$with_interrupt_tests" == "xno"; then
> 
> I don't know if the right answer* is:
> 
>   I should have made a proper patch and check-portability knows to skip
>   .orig files.
> 
>   we should omit ~ files from check-portability tests

The right answer is to use pkgvi from pkgtools/pkgdiff.  It appears to
include functionality to work around broken editors that leave ~ files
lying around in the work area for extra bonus points.

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com