Re: Implement dash as bootstrap shell

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2015-12-05 at 23:21 GMT, Greg Troxel wrote:

> Jonathan Perkin <jperkin%joyent.com@localhost> writes:
> 
> >>   resulting in the --enable-dash option going away,
> >>   because it will just be used on platforms where pkgsrc knows that
> >>   /bin/sh is not ok?
> >
> > No, I'll leave --with-dash.  For example, on OSX the default bootstrap
> > shell will be /bin/bash, but users may want to use --with-dash to get
> > a much faster shell.  I'll certainly be doing this for my bulk builds.
> >
> > It's also useful on Debian/Ubuntu where their dash (/bin/sh) doesn't
> > have the octal patch we include so cannot be used for bootstrap.
> 
> I don't object, but those sound like good reasons to make using dash on
> those platforms the default.  Any reason not to?

The main drawback with using a pkgsrc-installed shell as the default
is that you can hose your system with a bad upgrade procedure.
Perform a normal remove+install upgrade of the shell package and the
install will fail as pkg_add cannot execute the shell scripts as its
shell no longer exists.

It's safer to default to the system shell if it's suitable.

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com