Re: Removing find-prefix infrastructure

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2015-10-01 at 18:38 BST, Thomas Klausner wrote:

> On Thu, Oct 01, 2015 at 09:57:02AM +0100, Jonathan Perkin wrote:
> > The diff is quite large, but is essentially replacing any FIND_PREFIX
> > usage with either:
> > 
> >   BUILDLINK_PREFIX.pkg if pulled in via buildlink3.mk
> >   LOCALBASE if pulled in via DEPENDS
> > 
> > The diff URL:
> > 
> >   https://github.com/joyent/pkgsrc/compare/trunk...joyent:joyent/review/find-prefix
> 
> There are two chunks for editors/xemacs* that looks like they might
> belong to a separate cleanup commit.

It's related - the only reason editors/xemacs/Makefile.pkg exists is
to calculate XEMACS_PREFIX using EVAL_PREFIX (which uses find-prefix).
This variable is then completely unused, hence the removal of the
entire file.

> x11rec changes a DEPENDS into a bl3.mk include -- if it doesn't use
> libraries or headers, the DEPENDS looks better to me.

Yeh ok, saves time during buildlink wrapper phase too.

> Does superlu have LOCALBASE defined in the package Makefile or should
> it use PREFIX?

It doesn't.

Thanks,

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com