Re: CVS commit: pkgsrc/mk

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Sat, Mar 07, 2015 at 09:22:27PM +0100, Tobias Nygren wrote:
> On Sat, 7 Mar 2015 19:07:05 +0100
> Tobias Nygren <tnn%NetBSD.org@localhost> wrote:
> 
> > On Sat, 7 Mar 2015 18:45:04 +0100
> > Alistair Crooks <agc%pkgsrc.org@localhost> wrote:
> > 
> > > I wish this had been discussed prior to bringing in - it's an infrastructure
> > > change, and so would have been nice to talk about various issues I have with this
> > > when not in reactionary mode.
> > 
> > Fair enough. I did not consider the change to be that major but I
> > will not recommend it for any more packages until concerns have been
> > settled.
> 
> Hi!
> 
> I'm not sure I understood everything, but I thought about your
> concerns a bit and came up with this change. Is this satisfactory?
> 
> 1) turn _USE_GITHUB into internal infrastructure variable
> 2) put back MASTER_SITES
> 3) encode the account in the master site URL, remove GH_ACCOUNT
> 4) rename GH_PROJECT to GITHUB_PROJECT
> 5) rename GH_TAGNAME to GITHUB_TAG and allow it to accept commit hash
>    as well as tag. GH_COMMIT is gone.
> 6) magically turn on this functionality when MASTER_SITES matches
>    a predefined github pattern instead of via explicit USE_GITHUB.
> 
> Kind regards,
> -Tobias

This is brilliant - thanks for your prompt response, and for dealing
with all of my issues.

Many thanks,
Alistair