[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg/46254: libxml2 fails to avoid getting linked against libpthread on SunOS
On Sat, 31 Mar 2012 09:01:07 +0900, Joerg Sonnenberger
On Sat, Mar 31, 2012 at 12:46:40AM +0900, OBATA Akio wrote:
3. NetBSD<4.99.36 does not have pthread_equal stubs in libc,
so set weak ref for it.
I don't think that is correct. It will call a null-pointer if ever
invoked, right? Just provide an inline stub using == on the pointers.
As I said,
(phtread_* will be never used unless libxml2 will be used with pthread)
Please refer xmlInitThreads() in threads.c, if any of pthread_* is NULL,
thread support will not be ON (libxml_is_threaded == 0).
With your approach, pthread_equal() will not be used even if pthread is
really enabled. I feel it is bad situation.
Still incorrect for you?
OBATA Akio / obache%NetBSD.org@localhost
Main Index |
Thread Index |