Re: patch for REQUIRES

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Sun, Mar 18, 2012 at 01:55:44PM +0100, Filip Hajny wrote:
> I'd like to commit the following patch before the freeze, which I have been 
> using locally for some time. It makes sure that libs provided in a package 
> are not recorded in REQUIRES of the same package.

I don't see that happening for me right now.

> Without the patch, for instance 'expat' has /usr/lib/libexpat.so.1 (or 
> whatever else 'ldd' resolved under the DESTDIR environment) recorded in its 
> REQUIRES, even though the binary (xmlwf) is in fact linked against the 
> package's own libexpat.so.1. Some other packages (ffmpeg, poco and some 
> others I think) will even record libs with path starting with 
> ${DESTDIR}${PREFIX}.

Here's the pkg_summary entry for expat:
PKGNAME=expat-2.0.1nb2
COMMENT=XML parser library written in C
SIZE_PKG=678607
BUILD_DATE=2012-03-18 13:21:08 +0000
CATEGORIES=textproc
HOMEPAGE=http://expat.sourceforge.net/
LICENSE=
MACHINE_ARCH=x86_64
OPSYS=NetBSD
OS_VERSION=6.99.3
PKGPATH=textproc/expat
PKGTOOLS_VERSION=20091115
PROVIDES=/usr/pkg/lib/libexpat.so
PROVIDES=/usr/pkg/lib/libexpat.so.1
PROVIDES=/usr/pkg/lib/libexpat.so.1.5.2
REQUIRES=/usr/lib/libc.so.12
FILE_NAME=expat-2.0.1nb2.tgz
FILE_SIZE=193708
DESCRIPTION=This is James Clark's expat XML parser library in C. It is a stream 
oriented
DESCRIPTION=parser that requires setting handlers to deal with the structure 
that the
DESCRIPTION=parser discovers in the document.
DESCRIPTION=
DESCRIPTION=Homepage:
DESCRIPTION=http://expat.sourceforge.net/

Here's the one for ffmpeg:
PKGNAME=ffmpeg-20120112.0.7.11nb3
DEPENDS=libtheora>=1.0alpha3nb1
DEPENDS=libvorbis>=1.1.0nb1
DEPENDS=lame>=3.98.2nb1
DEPENDS=xvidcore>=1.1.0nb1
DEPENDS=x264-devel>=20111207
DEPENDS=libvpx>=1.0.0
COMMENT=Decoding, encoding and streaming software
SIZE_PKG=18335689
BUILD_DATE=2012-03-16 02:10:12 +0000
CATEGORIES=multimedia
HOMEPAGE=http://ffmpeg.mplayerhq.hu/
LICENSE=
MACHINE_ARCH=x86_64
OPSYS=NetBSD
OS_VERSION=6.99.3
PKGPATH=multimedia/ffmpeg
PKGTOOLS_VERSION=20091115
PKG_OPTIONS=lame libvpx theora vorbis x264 xvid
PREV_PKGPATH=multimedia/ffmpeg-devel
PROVIDES=/usr/pkg/lib/libavcodec.so
PROVIDES=/usr/pkg/lib/libavcodec.so.52
PROVIDES=/usr/pkg/lib/libavcodec.so.52.123.0
PROVIDES=/usr/pkg/lib/libavdevice.so
PROVIDES=/usr/pkg/lib/libavdevice.so.52
PROVIDES=/usr/pkg/lib/libavdevice.so.52.5.0
PROVIDES=/usr/pkg/lib/libavfilter.so
PROVIDES=/usr/pkg/lib/libavfilter.so.1
PROVIDES=/usr/pkg/lib/libavfilter.so.1.80.0
PROVIDES=/usr/pkg/lib/libavformat.so
PROVIDES=/usr/pkg/lib/libavformat.so.52
PROVIDES=/usr/pkg/lib/libavformat.so.52.111.0
PROVIDES=/usr/pkg/lib/libavutil.so
PROVIDES=/usr/pkg/lib/libavutil.so.50
PROVIDES=/usr/pkg/lib/libavutil.so.50.43.0
PROVIDES=/usr/pkg/lib/libpostproc.so
PROVIDES=/usr/pkg/lib/libpostproc.so.51
PROVIDES=/usr/pkg/lib/libpostproc.so.51.2.0
PROVIDES=/usr/pkg/lib/libswscale.so
PROVIDES=/usr/pkg/lib/libswscale.so.0
PROVIDES=/usr/pkg/lib/libswscale.so.0.14.1
REQUIRES=/lib/libgcc_s.so.1
REQUIRES=/usr/lib/libbz2.so.1
REQUIRES=/usr/lib/libc.so.12
REQUIRES=/usr/lib/libgcc_s.so.1
REQUIRES=/usr/lib/libm.so.0
REQUIRES=/usr/lib/libossaudio.so.1
REQUIRES=/usr/lib/libpthread.so.1
REQUIRES=/usr/lib/librt.so.1
REQUIRES=/usr/lib/libz.so.1
REQUIRES=/usr/pkg/lib/libmp3lame.so.0
REQUIRES=/usr/pkg/lib/libogg.so.0
REQUIRES=/usr/pkg/lib/libtheora.so.0
REQUIRES=/usr/pkg/lib/libtheoradec.so.1
REQUIRES=/usr/pkg/lib/libtheoraenc.so.1
REQUIRES=/usr/pkg/lib/libvorbis.so.0
REQUIRES=/usr/pkg/lib/libvorbisenc.so.2
REQUIRES=/usr/pkg/lib/libvpx.so.1
REQUIRES=/usr/pkg/lib/libx264.so.0
REQUIRES=/usr/pkg/lib/libxvidcore.so.4
FILE_NAME=ffmpeg-20120112.0.7.11nb3.tgz
FILE_SIZE=7230772
DESCRIPTION=FFmpeg is a complete, cross-platform solution to record, convert
DESCRIPTION=and stream audio and video.  It includes libavcodec - the leading
DESCRIPTION=audio/video codec library.
DESCRIPTION=
DESCRIPTION=Homepage:
DESCRIPTION=http://ffmpeg.mplayerhq.hu/

> Objections?

Yes, "works for me"...
 Thomas