Re: Maybe it's time to adopt extra testing for certain packages with high number of dependencies

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

Hi,

By the way, attached patch for devel/glib2 is acceptable?
At least on my DragonFly/i386 box and NetBSD/i386 6.99.3 box,
it works well.

Thank you.

-- 
Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3

$NetBSD: patch-ba,v 1.8 2012/01/29 10:46:54 drochner Exp $

http://bugzilla.gnome.org/show_bug.cgi?id=583330

--- gio/gunixmounts.c.orig      2011-11-11 17:56:52.000000000 +0000
+++ gio/gunixmounts.c
@@ -153,6 +153,9 @@ struct _GUnixMountMonitor {
 
   GFileMonitor *fstab_monitor;
   GFileMonitor *mtab_monitor;
+
+  guint mount_poller_source;
+  GList *mount_poller_mounts;
 };
 
 struct _GUnixMountMonitorClass {
@@ -164,6 +167,8 @@ static GUnixMountMonitor *the_mount_moni
 static GList *_g_get_unix_mounts (void);
 static GList *_g_get_unix_mount_points (void);
 
+static guint64 mount_poller_time = 0;
+
 G_DEFINE_TYPE (GUnixMountMonitor, g_unix_mount_monitor, G_TYPE_OBJECT);
 
 #define MOUNT_POLL_INTERVAL 4000
@@ -190,6 +195,7 @@ G_DEFINE_TYPE (GUnixMountMonitor, g_unix
 #endif
 
 #if (defined(HAVE_GETVFSSTAT) || defined(HAVE_GETFSSTAT)) && 
defined(HAVE_FSTAB_H) && defined(HAVE_SYS_MOUNT_H)
+#include <sys/param.h>
 #include <sys/ucred.h>
 #include <sys/mount.h>
 #include <fstab.h>
@@ -240,22 +246,30 @@ g_unix_is_mount_path_system_internal (co
     "/",              /* we already have "Filesystem root" in Nautilus */ 
     "/bin",
     "/boot",
+    "/compat/linux/proc",
+    "/compat/linux/sys",
     "/dev",
     "/etc",
     "/home",
     "/lib",
     "/lib64",
+    "/libexec",
     "/live/cow",
     "/live/image",
     "/media",
     "/mnt",
     "/opt",
+    "/rescue",
     "/root",
     "/sbin",
     "/srv",
     "/tmp",
     "/usr",
+    "/usr/X11R6",
     "/usr/local",
+    "/usr/obj",
+    "/usr/ports",
+    "/usr/src",
     "/var",
     "/var/crash",
     "/var/local",
@@ -595,7 +609,7 @@ get_mtab_monitor_file (void)
 static GList *
 _g_get_unix_mounts (void)
 {
-#if defined(HAVE_GETVFSSTAT)
+#if defined(HAVE_GETVFSSTAT) && !defined(__DragonFly__)
   struct statvfs *mntent = NULL;
 #elif defined(HAVE_GETFSSTAT)
   struct statfs *mntent = NULL;
@@ -608,7 +622,7 @@ _g_get_unix_mounts (void)
   GList *return_list;
   
   /* Pass NOWAIT to avoid blocking trying to update NFS mounts. */
-#if defined(HAVE_GETVFSSTAT)
+#if defined(HAVE_GETVFSSTAT) && !defined(__DragonFly__)
   num_mounts = getvfsstat (NULL, 0, ST_NOWAIT);
 #elif defined(HAVE_GETFSSTAT)
   num_mounts = getfsstat (NULL, 0, MNT_NOWAIT);
@@ -618,7 +632,7 @@ _g_get_unix_mounts (void)
 
   bufsize = num_mounts * sizeof (*mntent);
   mntent = g_malloc (bufsize);
-#if defined(HAVE_GETVFSSTAT)
+#if defined(HAVE_GETVFSSTAT) && !defined(__DragonFly__)
   num_mounts = getvfsstat (mntent, bufsize, ST_NOWAIT);
 #elif defined(HAVE_GETFSSTAT)
   num_mounts = getfsstat (mntent, bufsize, MNT_NOWAIT);
@@ -634,9 +648,15 @@ _g_get_unix_mounts (void)
       
       mount_entry->mount_path = g_strdup (mntent[i].f_mntonname);
       mount_entry->device_path = g_strdup (mntent[i].f_mntfromname);
+#if defined(__digital__)
+      mount_entry->filesystem_type = g_strdup ("unknown");
+#else
       mount_entry->filesystem_type = g_strdup (mntent[i].f_fstypename);
-#if defined(HAVE_GETVFSSTAT)
+#endif
+#if defined(HAVE_GETVFSSTAT) && !defined(__DragonFly__)
       if (mntent[i].f_flag & ST_RDONLY)
+#elif defined(__digital__)
+      if (mntent[i].f_flags & M_RDONLY)
 #elif defined(HAVE_GETFSSTAT)
       if (mntent[i].f_flags & MNT_RDONLY)
 #endif
@@ -1111,6 +1131,10 @@ get_mounts_timestamp (void)
       if (stat (monitor_file, &buf) == 0)
        return (guint64)buf.st_mtime;
     }
+  else
+    {
+      return mount_poller_time;
+    }
   return 0;
 }
 
@@ -1253,6 +1277,13 @@ g_unix_mount_monitor_finalize (GObject *
       g_object_unref (monitor->mtab_monitor);
     }
 
+  if (monitor->mount_poller_source > 0)
+    {
+      g_source_remove (monitor->mount_poller_source);
+      g_list_foreach (monitor->mount_poller_mounts, (GFunc)g_unix_mount_free, 
NULL);
+      g_list_free (monitor->mount_poller_mounts);
+    }
+
   the_mount_monitor = NULL;
 
   G_OBJECT_CLASS (g_unix_mount_monitor_parent_class)->finalize (object);
@@ -1333,6 +1364,51 @@ mtab_file_changed (GFileMonitor      *mo
   g_signal_emit (mount_monitor, signals[MOUNTS_CHANGED], 0);
 }
 
+static gboolean
+mount_change_poller (gpointer user_data)
+{
+  GUnixMountMonitor *mount_monitor;
+  GList *current_mounts;
+  gboolean has_changed = FALSE;
+
+  mount_monitor = user_data;
+  current_mounts = _g_get_unix_mounts ();
+
+  if (g_list_length (current_mounts) != g_list_length 
(mount_monitor->mount_poller_mounts))
+    {
+      g_list_foreach (mount_monitor->mount_poller_mounts, 
(GFunc)g_unix_mount_free, NULL);
+      has_changed = TRUE;
+    }
+  else
+    {
+      int i;
+
+      for (i = 0; i < g_list_length (current_mounts); i++)
+        {
+          GUnixMountEntry *m1;
+         GUnixMountEntry *m2;
+
+         m1 = (GUnixMountEntry *)g_list_nth_data (current_mounts, i);
+         m2 = (GUnixMountEntry *)g_list_nth_data 
(mount_monitor->mount_poller_mounts, i);
+          if (! has_changed && g_unix_mount_compare (m1, m2) != 0)
+            has_changed = TRUE;
+
+         g_unix_mount_free (m2);
+       }
+    }
+
+  g_list_free (mount_monitor->mount_poller_mounts);
+  mount_monitor->mount_poller_mounts = current_mounts;
+
+  if (has_changed)
+    {
+      mount_poller_time = (guint64)time (NULL);
+      g_signal_emit (mount_monitor, signals[MOUNTS_CHANGED], 0);
+    }
+
+  return TRUE;
+}
+
 static void
 g_unix_mount_monitor_init (GUnixMountMonitor *monitor)
 {
@@ -1355,6 +1431,12 @@ g_unix_mount_monitor_init (GUnixMountMon
       
       g_signal_connect (monitor->mtab_monitor, "changed", 
(GCallback)mtab_file_changed, monitor);
     }
+  else
+    {
+      monitor->mount_poller_mounts = _g_get_unix_mounts ();
+      mount_poller_time = (guint64)time (NULL);
+      monitor->mount_poller_source = g_timeout_add_seconds (3, 
(GSourceFunc)mount_change_poller, monitor);
+    }
 }
 
 /**