tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: OWN_DIRS doesn't protect directories as advertised

On Fri, Nov 18, 2011 at 04:14:00PM +0900, OBATA Akio wrote:
> On Thu, 17 Nov 2011 23:31:14 +0900, Joerg Sonnenberger 
> <> wrote:
> >On Thu, Nov 17, 2011 at 06:17:19PM +0900, OBATA Akio wrote:
> >>I feel that pkg_delete(1) should be fixed.
> >>Before removal of directory, check not only empty, but also refcount db.
> >
> >I disagree. This instances should be properly using @pkgdir.
> Do you want to say as followings?
>  Before removal of directory, check not only empty, but also check ALL other
>  packages' +CONTENTS whether @pkgdir for the directory exists or not.
>  And on package creation, OWN_DIRS must be registered to +CONTENTS as @pkgdir.

Basically, it matters only if a directory is both in OWN_DIRS /
MAKE_DIRS and other packages have files in it. That's a classic
candidate for just making it @pkgdir in first place. A bunch of cases
where converted, but it's no surprise that some where missed.


Home | Main Index | Thread Index | Old Index