libmemcached and include paths

["Filip Hajny" <filip%joyent.com@localhost>]

Hi guys,

I'm attempting to bump wip/php-memcached (and subsequently wip/libmemcached 
too) to more recent versions, and hit a problem with include paths as defined 
by libmemcached/buildlink3.mk. The problem is that php_memcached.c triggers 
(through PHP's php_config.h) the inclusion of the system string.h header file, 
however that conflicts with ${PREFIX}/include/libmemcached/string.h.

Obviously I could just change the libmemcached/buildlink3.mk file to not add 
the ${PREFIX}/include/libmemcached include path to the chain, but that may 
break something elsewhere. I was wondering, is there a common way out of this, 
or is it just an unfortunate file naming on the part of libmemcached?

The resulting gcc line is as follows (this is on Solaris snv_89):

gcc -I/opt/local/include/php -I. 
-I/tmp/pkgsrc/wip/php-memcached/work/memcached-1.0.2 -DPHP_ATOM_INC 
-I/tmp/pkgsrc/wip/php-memcached/work/memcached-1.0.2/include 
-I/tmp/pkgsrc/wip/php-memcached/work/memcached-1.0.2/main 
-I/tmp/pkgsrc/wip/php-memcached/work/memcached-1.0.2 -I/opt/local/include/php 
-I/opt/local/include/php/main -I/opt/local/include/php/TSRM 
-I/opt/local/include/php/Zend -I/opt/local/include/php/ext 
-I/opt/local/include/php/ext/date/lib -I/opt/local/include 
-I/opt/local/include/libmemcached -I/opt/local/include -I/usr/include 
-DHAVE_CONFIG_H -O -I/opt/local/include/libmemcached -I/opt/local/include 
-I/usr/include -c 
/tmp/pkgsrc/wip/php-memcached/work/memcached-1.0.2/php_memcached.c  -fPIC -DPIC 
-o .libs/php_memcached.o

-F