Thomas Klausner <wiz%NetBSD.org@localhost> writes:
> I like this patch, just two things:
Thanks for the review.
> First one, minor:
>> +.if defined(PYDISTUTILS_NO_EGGFILES)
>
> Please use positive variables, e.g. PYDISTUTILS_CREATES_EGGFILES and
> check for it being "yes"
OK, am changing that.
>> +PY_NO_EGG?= yes
> this variable should also be inverted and replaced with e.g. PY_EGG.
> (I know you didn't create this variable, so it's not necessary to fix
> it now.)
OK, will leave it for now, and really it should just go away.
>> diff -u -p -r1.4 PLIST
>> --- security/py-crypto/PLIST 23 Jul 2010 23:24:19 -0000 1.4
>> +++ security/py-crypto/PLIST 24 Jul 2010 01:39:23 -0000
>> @@ -265,4 +265,4 @@ ${PYSITELIB}/Crypto/__init__.pyo
>> ${PYSITELIB}/Crypto/pct_warnings.py
>> ${PYSITELIB}/Crypto/pct_warnings.pyc
>> ${PYSITELIB}/Crypto/pct_warnings.pyo
>> -${PYSITELIB}/${EGG_FILE}
>> +${EGG_MAYBE}${PYSITELIB}/${EGG_FILE}
>
> IIUC, this is not needed?
It is necessary because when built under Python 2.4 the egg file will
not be created, but under 2.5+ it will be.
I am changing to PLIST.eggfile yes/no, since manual @comment is so 90s.
I believe, but am not 100% certain yet, that all distutils packages will
behave this way, and that if there are non-distutils extensions all bets
are off anyway and they are special cased.
Attachment:
pgpjMfl5S72IC.pgp
Description: PGP signature