Re: patch: handling python distutils and egg files

[Thomas Klausner <wiz%NetBSD.org@localhost>]

Hi Greg!

I like this patch, just two things:

First one, minor:
> +.if defined(PYDISTUTILS_NO_EGGFILES)

Please use positive variables, e.g. PYDISTUTILS_CREATES_EGGFILES and
check for it being "yes"
> +PY_NO_EGG?=  yes
this variable should also be inverted and replaced with e.g. PY_EGG.
(I know you didn't create this variable, so it's not necessary to fix
it now.)

> diff -u -p -r1.4 PLIST
> --- security/py-crypto/PLIST  23 Jul 2010 23:24:19 -0000      1.4
> +++ security/py-crypto/PLIST  24 Jul 2010 01:39:23 -0000
> @@ -265,4 +265,4 @@ ${PYSITELIB}/Crypto/__init__.pyo
>  ${PYSITELIB}/Crypto/pct_warnings.py
>  ${PYSITELIB}/Crypto/pct_warnings.pyc
>  ${PYSITELIB}/Crypto/pct_warnings.pyo
> -${PYSITELIB}/${EGG_FILE}
> +${EGG_MAYBE}${PYSITELIB}/${EGG_FILE}

IIUC, this is not needed?
 Thomas