tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Sections in Makefile (Makefile-example v.s. pkglint)



Alistair Crooks schrieb:
On Fri, Jul 16, 2010 at 08:56:17PM +0900, OBATA Akio wrote:
Hi,

For LICENSE line, it is exactly after COMMENT in pkgsrc/doc/Makefile-example. But for pkglint, it is expected that it is in the next "Legal issues" section
(RESTRICTED, NO_*_ON_*).  Which is correct?

I talked with numerous people when the licensing info was extended for
all packages, and our consensus was that this is pertinent to the
metadata on the package itself, so it sits best where it is. Personally, I'm happy we have this information anywhere in the
Makefile, and don't understand why it needs to be in a single,
immutable and unmoving position, but I realise I'm at odds with
certain parts of the developer community on this one.

----
$ cvs log -r1.693 pkglint.pl
revision 1.693
date: 2007/01/15 08:45:59;  author: rillig;  state: Exp;  lines: +27 -10
Now it's possible to define optional sections when checking the variable
order in package Makefiles. This allows for a legal section, which is
also added. I'm not yet sure about the correct order of all these
variables.
----

So feel free to merge the legal section with the "Unsorted stuff, part 2" (pkglint.pl, around line 5900). And while you're at it, maybe you can find some better names for the "Unsorted stuff" sections. Back then I couldn't. The section names in pkglint.pl are purely for documentation. They are not used in the code.

Roland


Home | Main Index | Thread Index | Old Index