tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: postgresql84-client: pgxs makefiles not installed (patch)

Adam CiarciÅski <> writes:

>> Hi Greg,
>> I was about to do the same. Actually have made the same modification
>> to my local git clone of pkgsrc a couple of weeks ago, and do have a
>> postgis package. If you import your postgis package, make sure to
>> make it universal so that it can be made compatible with 83
>> etc. too.
>>> but the package does not install that.  The following patch
>>> installs the
>>> files that postgis expects from the pgxs hierarchy.  The only tricky
>>> part is removing workdir references from the tool paths built into
>>> the
>>> makefile.  With this patch the postgis build is to the point where
>>> it is
>>> running into its own issues, or something tricky with the pgxs
>>> system.
>> You can sed away the workdir paths cleanly using ${WRKDIR} in the
>> sed pattern.
>> My patch is pretty much the same, and confirmed working on Solaris.
> I am also working on postgis, but I include Makefile.common from
> postgresql84, unpack postgres along with postgis, let both configure
> and other hacks to make use of and other makefiles. Which do
> you think is a better approach? Since the makefiles are needed only to
> build postgis.

The makefiles are very small, and it seems unnecessary for postgresql
modules to have to unpack pgsql source just to get them.  Any other
postgresql module will need the same makefiles, although I can believe
there won't be that many.  I think it's far preferable to install 6
small files than to have to unpack and configure another package to
build a package.  Plus, the pgxs makefile is specified to be where I put
it by pg_config.  Perhaps this is a bug in upstream postgresql, or
perhaps it's our fault, but it's easy to fix.

Are either of you on the postgis list?  I've been posting there about
problems and didn't know any of you were working on this.

Filip: Unless Adam objects, I would be happy for you to commit your
patch and I'll then check the merge/conflict with mine and speak up if
there's any residual value.

I don't have support for multiple pg versions in my postgis package.
I'm happy to have you import yours and I'll then take a look.

Attachment: pgp7kwbXXJvzE.pgp
Description: PGP signature

Home | Main Index | Thread Index | Old Index