[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: The NetBSD perfect patch!
On Sat, 21 Nov 2009, Joerg Sonnenberger wrote:
> cvs diff -upN is normally a good start.
Dose anyone use anything but unified diffs?
Puting "diff -upN" in .cvsrc is recommended in the pkgsrc guide.
> use pkgtools/pkgdiff.
To be more specific:
Should diffs be done for the toplevel module directroys (eg. /usr/pkgsrc)
or are subdirectorys or (eg. pkgtools/pkgdiff or pkgtools/pkgdiff/files)?
'patch -p1' or 'patch -p0'?
In-line or as attachments?
For multiple patches, one pre email or all together?
Have a ready cvs commint message in or as the body?
Start the subject with "[patch]" or "[patch 1/3]"?
Should there be a "Signed-off-by:" line?
Should new files or files in 'patches' subdirectorys (made with
pkgtools/pkgdiff) be sent directly or as 'cvs diff' output?
I can understand if there are no preferances for some of these questions,
and if there are differances for PRs.
How should I know if it works? That's what beta testers are for. I
only coded it.
-- Attributed to Linus Torvalds, somewhere in a posting
Main Index |
Thread Index |