tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Missing argument in pkg-changes2html

I asked this back in July and no one has answered.  Here is the
question again.  I have also added a proposed patch.  I'm 99% sure so I
guess I should just assume that it was too obvious to Perl programmers
and commit unless someone disagrees.

I'm not a Perl programmer so perhaps I am missing something but isn't
fail() missing an argument in htutils/changes/pkg-changes2html line 171
that tells it whether to send an email on error?

Index: htutils/changes/pkg-changes2html
RCS file: /cvsroot/htutils/changes/pkg-changes2html,v
retrieving revision 1.16
diff -u -p -r1.16 pkg-changes2html
--- htutils/changes/pkg-changes2html    12 Jul 2009 05:08:39 -0000      1.16
+++ htutils/changes/pkg-changes2html    26 Aug 2009 11:56:39 -0000
@@ -168,7 +168,7 @@ sub parse_file
        my %pkgs;
        my $id;
-       open(CHANGES, "$pkgsrcdir/$infile") || fail("Unable to open '$infile': 
+       open(CHANGES, "$pkgsrcdir/$infile") || fail('', "Unable to open 
'$infile': $!");
        @data =<CHANGES>;

D'Arcy J.M. Cain <>

Home | Main Index | Thread Index | Old Index