Re: string seperator problem with SMART_MESSAGES

[Jukka Salmi <j+nbsd%2009.salmi.ch@localhost>]

Jukka Salmi --> tech-pkg (2009-05-05 14:20:34 +0200):
> Hello,
> 
> building with SMART_MESSAGES defined seems to print the package's name
> and those of its dependencies simply concatenated, e.g. without a string
> separator as this used to be IIRC.
> 
> For example, while building devel/scmgit with SMART_MESSAGES defined I
> see: 
> 
> [...]
> ===> depends-message [p5-Error-0.17015nb1scmgit-base-1.6.2.5 scmgit-1.6.2.5 ] 
> ===> Installing dependencies for p5-Error-0.17015nb1
> => Build dependency checkperms>=1.1: found checkperms-1.10
> => Full dependency perl<5.12.0: found perl-5.10.0nb4
> => Full dependency perl>=5.10.0: found perl-5.10.0nb4
> ===> tools-message [p5-Error-0.17015nb1scmgit-base-1.6.2.5 scmgit-1.6.2.5 ] 
> ===> Overriding tools for p5-Error-0.17015nb1
> ===> extract-message [p5-Error-0.17015nb1scmgit-base-1.6.2.5 scmgit-1.6.2.5 ] 
> ===> Extracting for p5-Error-0.17015nb1
> ===> patch-message [p5-Error-0.17015nb1scmgit-base-1.6.2.5 scmgit-1.6.2.5 ] 
> ===> Patching for p5-Error-0.17015nb1
> ===> wrapper-message [p5-Error-0.17015nb1scmgit-base-1.6.2.5 scmgit-1.6.2.5 ] 
> ===> Creating toolchain wrappers for p5-Error-0.17015nb1
> ===> configure-message [p5-Error-0.17015nb1scmgit-base-1.6.2.5 scmgit-1.6.2.5 
> ] ===> Configuring for p5-Error-0.17015nb1
> [...]

It seems to me that this was intoduced with the most recent change of
pkgsrc/mk/flavor/pkg/depends.mk.  The attached patch should fix the
problem.


Regards, Jukka

[1] 
http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/mk/flavor/pkg/depends.mk.diff?r1=1.43&r2=1.44

-- 
This email fills a much-needed gap in the archives.

Index: mk/flavor/pkg/depends.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/flavor/pkg/depends.mk,v
retrieving revision 1.44
diff -u -p -r1.44 depends.mk
--- mk/flavor/pkg/depends.mk    6 Feb 2009 15:27:00 -0000       1.44
+++ mk/flavor/pkg/depends.mk    5 May 2009 14:29:13 -0000
@@ -79,7 +79,7 @@ _DEPENDS_INSTALL_CMD=                                         
        \
                ${STEP_MSG} "Verifying $$target for $$dir";             \
                [ -d "$$dir" ] || ${FAIL_MSG} "[depends.mk] The directory 
\`\`$$dir'' does not exist."; \
                cd $$dir;                                               \
-               ${SETENV} ${PKGSRC_MAKE_ENV} _PKGSRC_DEPS="${PKGNAME} 
${_PKGSRC_DEPS}" PKGNAME_REQD="$$pattern" ${MAKE} ${MAKEFLAGS} _AUTOMATIC=yes 
$$target; \
+               ${SETENV} ${PKGSRC_MAKE_ENV} _PKGSRC_DEPS=" 
${PKGNAME}${_PKGSRC_DEPS}" PKGNAME_REQD="$$pattern" ${MAKE} ${MAKEFLAGS} 
_AUTOMATIC=yes $$target; \
                pkg=`${_PKG_BEST_EXISTS} "$$pattern" || ${TRUE}`;       \
                case "$$pkg" in                                         \
                "")     ${ERROR_MSG} "[depends.mk] A package matching 
\`\`$$pattern'' should"; \
@@ -142,10 +142,10 @@ pkg_install-depends:
        ${RUN}if [ `${PKG_INFO_CMD} -V 2>/dev/null || echo 20010302` -lt 
${PKGTOOLS_REQD} ]; then \
        ${PHASE_MSG} "Trying to handle out-dated pkg_install..."; \
        cd ../../pkgtools/pkg_install && ${SETENV} ${PKGSRC_MAKE_ENV} \
-           _PKGSRC_DEPS="${PKGNAME} ${_PKGSRC_DEPS}" \
+           _PKGSRC_DEPS=" ${PKGNAME}${_PKGSRC_DEPS}" \
            ${MAKE} ${MAKEFLAGS} _AUTOMATIC=yes clean && \
        cd ../../pkgtools/pkg_install && ${SETENV} ${PKGSRC_MAKE_ENV} \
-           _PKGSRC_DEPS="${PKGNAME} ${_PKGSRC_DEPS}" \
+           _PKGSRC_DEPS=" ${PKGNAME}${_PKGSRC_DEPS}" \
            ${MAKE} ${MAKEFLAGS} _AUTOMATIC=yes ${DEPENDS_TARGET:Q}; \
        fi