[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkglint question - PLIST_VARS vs PLIST_SRC+= & PLIST_SUBST
On 06/03/2009 16:45, David Brownlee wrote:
> On Fri, 6 Mar 2009, Adrian Portelli wrote:
>> On 06/03/2009 16:22, David Brownlee wrote:
>>> Is the general recommended way to conditionalise certain
>>> elements in a PLIST to use PLIST_VARS rather than PLIST_SUBST
>>> or PLIST_SRC+= ?
>>> Should pkglint be giving hints on this?
>> If it's just based on something like extra files included from an
>> option.mk being chosen I tend to use PLIST_VARS. But I do believe
>> PLIST_SUBST has it's place if you need to customise the replaced text.
>> I think PLIST_SRC+= has seen its day.
> So potentially pkglint could warn if it sees a PLIST_SUBST
> at the start of a line in PLIST (or set to @comment), or
> any usage of PLIST_SRC+= ?
Personally, I'd leave PLIST_SUBST alone and mark PLIST_SRC depreciated.
Main Index |
Thread Index |