tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

amanda: expressing defaults again in Makefile?



I am needing amanda on a small-memory sparc, and am thus newly motivated
to make the default packages acceptable to me.  I am taking a cleanup
pass on the packages, and noticed that AMANDA_{USER,TMP,VAR} are in
/usr/pkgsrc/mk/default/mk.conf.  I am guessing that they should
therefore not be defined in the makefile, and have the following patch.
OK to commit, or am I confused?

Barring objections, I will also be making AMANDA_FQDN and AMANDA_SSH the 
default, perhaps
without even an option, because I now of no good reason why they should
ever be off.

Index: sysutils/amanda-common/Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/sysutils/amanda-common/Makefile.common,v
retrieving revision 1.27
diff -u -p -r1.27 Makefile.common
--- sysutils/amanda-common/Makefile.common      29 Jul 2008 17:21:39 -0000      
1.27
+++ sysutils/amanda-common/Makefile.common      1 Mar 2009 18:47:01 -0000
@@ -10,7 +10,7 @@ DISTNAME?=            amanda-${VERS}
 CATEGORIES=            sysutils
 MASTER_SITES?=         ${MASTER_SITE_SOURCEFORGE:=amanda/}
 
-MAINTAINER=            pkgsrc-users%NetBSD.org@localhost
+MAINTAINER=            gdt%NetBSD.org@localhost
 HOMEPAGE=              http://www.amanda.org/
 
 .include "../../mk/bsd.prefs.mk"
@@ -22,10 +22,6 @@ AMANDA_GROUP?=               sysadmin
 AMANDA_GROUP?=         operator
 .endif
 
-AMANDA_USER?=          backup
-AMANDA_TMP?=           /tmp/amanda
-AMANDA_VAR?=           ${VARBASE}/amanda
-
 PKG_GROUPS_VARS+=      AMANDA_GROUP
 PKG_USERS_VARS+=       AMANDA_USER
 BUILD_DEFS+=           AMANDA_TMP AMANDA_VAR VARBASE

Attachment: pgpO2iuzwW3_l.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index