Re: CVS commit: pkgsrc/mk

[Eric Gillespie <epg%pretzelnet.org@localhost>]

Tobias Nygren writes:

> 
> Module Name:  pkgsrc
> Committed By: tnn
> Date:         Wed May 21 19:54:00 UTC 2008
> 
> Modified Files:
>       pkgsrc/mk: bsd.pkg.mk
> 
> Log Message:
> Commit a workaround for the "make replace fails as non-root" bug:
> Make sure _PKGSRC_BARRIER is set when using just-in-time su.
> I've been running this for a long time in my tree without ill effects.
> For more information see PR pkg/34470 and PR pkg/38505.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -r1.1941 -r1.1942 pkgsrc/mk/bsd.pkg.mk

This seems to have broken pkgsrc on Linux, or at least Ubuntu
Dapper and Hardy.  Specifically, pkgsrc Makefiles with targets
that directly run tools such as libtool and pax (or ${LIBTOOL}
and ${PAX}, for that matter) don't work.

archivers/bzip2 has a simple example:

RCS file: /cvsroot/pkgsrc/archivers/bzip2/Makefile,v
@@ -32,6 +32,9 @@
        ${CP} -r ${FILESDIR} ${WRKSRC}
 
 do-install:
+       : ${PATH}
+       echo $$PATH
+       : ${LIBTOOL}
        ${LIBTOOL} --mode=install ${INSTALL_LIB} ${WRKSRC}/libbz2.la 
${DESTDIR}${PREFIX}/lib

# Backdate an otherwise-2008Q2 tree's bsd.pkg.mk.
0 bzip2% (../.. && cvs -q up -r1.1941 mk/bsd.pkg.mk
P mk/bsd.pkg.mk
0 bzip2% bmake deinstall clean && bmake install
[...]
: 
/usr/pkgsrc/2008Q2/archivers/bzip2/work/.wrapper/bin:/usr/pkgsrc/2008Q2/archivers/bzip2/work/.buildlink/bin:/usr/pkgsrc/2008Q2/archivers/bzip2/work/.tools/bin:/usr/pkgsrc/2008Q2/archivers/bzip2/work/.gcc/bin:/usr/pkg-2008Q2/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/X11R6/bin:/sbin:/usr/sbin
echo $PATH
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/X11R6/bin:/sbin:/usr/sbin
: /usr/pkg-2008Q2/bin/libtool
[successful install]

# Backdate an otherwise-2008Q2 tree's bsd.pkg.mk.
0 bzip2% (../.. && cvs -q up -r1.1942 mk/bsd.pkg.mk
P mk/bsd.pkg.mk
0 bzip2% bmake deinstall clean && bmake install
[...]
: 
/usr/pkgsrc/2008Q2/archivers/bzip2/work/.wrapper/bin:/usr/pkgsrc/2008Q2/archivers/bzip2/work/.buildlink/bin:/usr/pkgsrc/2008Q2/archivers/bzip2/work/.tools/bin:/usr/pkgsrc/2008Q2/archivers/bzip2/work/.gcc/bin:/usr/pkg-2008Q2/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/X11R6/bin:/sbin:/usr/sbin
echo $PATH
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/X11R6/bin:/sbin:/usr/sbin
: libtool
libtool --mode=install /usr/bin/install -c -o root -g root -m 555 
/usr/pkgsrc/2008Q2/archivers/bzip2/work/bzip2-1.0.5/libbz2.la 
/usr/pkg-2008Q2/lib
/bin/sh: libtool: command not found

DOH!

-- 
Eric Gillespie <*> epg%pretzelnet.org@localhost