tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg_admin audit frontends

On Wed, Apr 09, 2008 at 02:42:38PM +0100, Adrian Portelli wrote:
> Joerg Sonnenberger wrote:
>> On Wed, Apr 09, 2008 at 10:58:34AM +0100, Adrian Portelli wrote:
>>> 1) count the number of entries in the file
>>> * IMHO this is cosmetic and could even be dropped
>> If we want to have an accurate list of vulnerabilities, I would prefer
>> to add support for matching against the base name. It gets a bit messy,
>> but I have some code around for that anyway.
> We spoke about this a while ago and that functionality would be good to 
> see.  It would also mean we could go back to listing all vulnerabilities 
> for a package in the README.html, as opposed to just current ones, if we 
> wanted to.

OK, I'll add that part first.

>>> 2) check the version of the file against what it expects it to be
>> I do not understand what you wrote here.
> genreadme.awk looks for the #FORMAT number inside the pkg-vulnerabilities 
> file and then matches it against the hard coded number in genreadme.awk.  
> If the #FORMAT number in the file pkg-vulnerabilities is greater than the 
> one in genreadme.awk it bails with an error.  See lines 268-297.

Ah, the format version. I was thinking you are talking about the
repository version and was confused :-) That check doesn't have to be
done at all, if it is just calling pkg_admin.


Home | Main Index | Thread Index | Old Index